Partial fixes to optix crates and examples. #159
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated `bitflags` has a few breaking changes: - it no longer adds traits like `Clone`, `Copy`, etc.. Add those explicitly. - An internal wrapper over the underlying flag type is used that isn't `DeviceCopy`. Define the struct wrapping the underlying type explictly, and use `bitflags!` to define the impl.
Contributor
|
Thanks! 🍻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes fixes errors when building
path_tracing_gpu. It is now able to build and generate ptx. Also migrates a deprecated API in thedenoiserexample.The host side still fails due to updated dependencies on its side.